[PATCH] D89691: [obj2yaml] - Add support of dumping archives.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 01:45:27 PDT 2020


jhenderson added a comment.

Honestly, I'm not convinced that just because we can, we should. There are good reasons for other tools like llvm-readelf to run over all archive members, but obj2yaml isn't, to my knowledge, used in a production environment or even in a testing environment where such functionality would prove particularly useful. Increasing code complexity in order to support it seems unwise to me.

I actually think there might be a slightly different approach to this, for which there might be a use-case: rather than dumping individual YAML blocks, add them all as "children" for an archive YAML block. That way, you can also see the non-binary members of the archive, e.g. the symbol table and the string table. This is probably more useful for the yaml2obj side, to allow testing of malformed archives in llvm-ar testing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89691/new/

https://reviews.llvm.org/D89691



More information about the llvm-commits mailing list