[PATCH] D89713: llvm-objcopy: extract arg parsing logic to function

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, with one suggestion.

Also, couple of notes about the summary:

1. Add `[NFC]` to the summary, as there is no functional change caused by this patch.
2. Tags tend to be in the form `[llvm-objcopy]` etc.



================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:336
 
 enum class ToolType { Objcopy, Strip, InstallNameTool, BitcodeStrip };
 
----------------
Can you delete this enum too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89713/new/

https://reviews.llvm.org/D89713