[PATCH] D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions
Amy Kwan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 00:07:46 PDT 2020
amyk added a comment.
Agreed that a test should be added.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1412
+
+let mayLoad = 1, mayStore = 0, hasSideEffects = 0, Predicates = [PairedVectorMemops, PrefixInstrs] in {
+ defm PLXVP :
----------------
steven.zhang wrote:
> amyk wrote:
> > Question: is the `hasSideEffects` necessary?
> Yes, it is needed as load/store instr also may have the sideeffects.
Right. Thanks for clarifying.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89727/new/
https://reviews.llvm.org/D89727
More information about the llvm-commits
mailing list