[PATCH] D89758: Unconditionally #include <future>

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 20:08:16 PDT 2020


GMNGeoffrey added a comment.

In D89758#2340716 <https://reviews.llvm.org/D89758#2340716>, @hubert.reinterpretcast wrote:

> We've been building with `LLVM_ENABLE_THREADS=0` to avoid dependencies on the TLS support in the build environment. We may require assistance to restore our builds if these patches introduce a TLS dependency. @daltenty, fyi.

The specific usage is in `ExecutionSession::lookupFlags`. `ExecutionSession::lookup` is implemented with a non-threaded alternative. If you want to look at doing that it would be an alternative fix. I see other cases of `#include <future>` not guarded by `LLVM_ENABLE_THREADS` though: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/llvm/llvm-project%24+%22%23include+%3Cfuture%3E%22+f:%5Ellvm/&patternType=regexp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89758/new/

https://reviews.llvm.org/D89758



More information about the llvm-commits mailing list