[PATCH] D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets.
Tom Tan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 19 19:57:24 PDT 2020
TomTan added inline comments.
================
Comment at: llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp:156
+ case COFF::IMAGE_FILE_MACHINE_I386:
+ RegNames = getRegisterNames(CPUType::Pentium3);
+ break;
----------------
nit: probably assign CPUType in the in switch case, then all calls to getRegisterNames can be consolidated?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89622/new/
https://reviews.llvm.org/D89622
More information about the llvm-commits
mailing list