[PATCH] D89742: [FileCollector] Move interface into FileCollectorBase (NFC)

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

This mostly looks good, I'm just wondering about tests. I hunted around for a `FileCollector` unit test and didn't see one, but it seems like it might be a good fit, especially if it gets you coverage things otherwise only used in LLDB. WDYT?



================
Comment at: llvm/include/llvm/Support/FileCollector.h:106-110
   void addFileImpl(StringRef SrcPath);
 
   llvm::vfs::directory_iterator
   addDirectoryImpl(const llvm::Twine &Dir,
                    IntrusiveRefCntPtr<vfs::FileSystem> FS, std::error_code &EC);
----------------
Seems like these should now have `override` on them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89742/new/

https://reviews.llvm.org/D89742