[PATCH] D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 16:59:06 PDT 2020


amyk accepted this revision.
amyk added a comment.
This revision is now accepted and ready to land.

I think it overall LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1412
+
+let mayLoad = 1, mayStore = 0, hasSideEffects = 0, Predicates = [PairedVectorMemops, PrefixInstrs] in {
+  defm PLXVP :
----------------
Question: is the `hasSideEffects` necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89727/new/

https://reviews.llvm.org/D89727



More information about the llvm-commits mailing list