[PATCH] D83069: [LIT] error if directly named test won't be run indirectly

Mon Oct 19 16:41:41 PDT 2020

bd1976llvm marked an inline comment as done.
bd1976llvm added inline comments.

================
Comment at: llvm/utils/lit/tests/discovery.py:144
+#
+# CHECK-ERROR-INDIRECT-RUN-CHECK: error: 'top-level-suite :: test.not-txt' would not be run indirectly
+
----------------
thopre wrote:
> Why not test the full error message?
I try to keep negative test cases from being too specific to try to prevent them from "failing for the wrong reason" (e.g. if in the future the error message is altered slightly then if we were checking the full error message the check would pass even though the, slightly altered, message is being emitted). However, looking at this again I don't think checking the output is worthwhile so I have removed it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83069/new/

https://reviews.llvm.org/D83069