[PATCH] D89738: [AMDGPU] Refactor SOPC & SOPP .td for extension

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

Are there hazards associated with SOP, where we have it lowered to real instructions?

Also please run PSDB for this change.



================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:954
+  // copy relevant pseudo op flags
+  let SubtargetPredicate = ps.SubtargetPredicate;
+  let AsmMatchConverter  = ps.AsmMatchConverter;
----------------
Can you copy OtherPredicates too? We always missing it.


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:974
 }
-class SOPC_Helper <bits<7> op, RegisterOperand rc, ValueType vt,
+class SOPC_Helper <RegisterOperand rc, ValueType vt,
                     string opName, SDPatternOperator cond> : SOPC_Base <
----------------
Please add a blank line.


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:1079
+  // copy relevant pseudo op flags
+  let SubtargetPredicate = ps.SubtargetPredicate;
+  let AsmMatchConverter  = ps.AsmMatchConverter;
----------------
Also copy OtherPredicates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89738/new/

https://reviews.llvm.org/D89738