[PATCH] D89739: [LCSSA] Doc for special treatment of PHIs
Stefanos Baziotis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 19 14:13:48 PDT 2020
baziotis added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LCSSA.cpp:177-178
PN->setDebugLoc(I->getDebugLoc());
- // Add inputs from inside the loop for this PHI.
+ // Add inputs from inside the loop for this PHI. This is valid
+ // because `I` dominates `ExitBB`.
for (BasicBlock *Pred : PredCache.get(ExitBB)) {
----------------
Ah, I just saw that. Do you want me to put it in a separate diff ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89739/new/
https://reviews.llvm.org/D89739
More information about the llvm-commits
mailing list