[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

"Edit Related Revisions" - please mark this as dependent on the `llvm/Support/CharSet.h` patch



================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:37
+/// limited to 16K bytes.
+const uint16_t MaxDataLength = 16 * 1024;
+
----------------



================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:263
+    Expected<StringRef> Name = getSymbolName(Symb);
+    if (Name && !Name->equals(" ")) { // blank name is local
+      Flags |= SymbolRef::SF_Global;
----------------
Prefer == != to equals


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:434
+bool GOFFObjectFile::getRLDIsCodeAddressReference(uint64_t RelocationType) {
+  bool IsCodeAddrReference = (RelocationType & RLD_CODE_ADDR_FLAG) != 0;
+  return IsCodeAddrReference;
----------------
Don't define a variable which is immediately used on the next line and not used in other places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89071/new/

https://reviews.llvm.org/D89071