[PATCH] D89721: [GWP-ASan] Cleanup (NFC)

[Mitch Phillips via Phabricator via llvm-commits]

hctim added a comment.

LGTM



================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp:31
 }
-#else  // __BIONIC__
+#else // __BIONIC__
 void Check(bool Condition, const char *Message) {
----------------
hctim wrote:
> cryptoad wrote:
> > hctim wrote:
> > > my `clang-format --style=LLVM` uses doublespace after `#else` as well, but not after `#endif`. hmm...
> > I tried a few combinations, with a gLinux stock clang-format, a freshly compiled one from ToT, and they all end up with 1 space.
> > The one at the top of the file for `stdio` also has 1 space.
> > 
> > Not sure what's the deal with that pre-merge check.
> Maybe me and the mergebot have our binaries from a bad revision. Let me check.
```
$ clang-format --version
clang-format version 10.0.0 (https://github.com/llvm/llvm-project.git af57dbf12e54f3a8ff48534bf1078f4de104c1cd)
$ clang-format z.cpp | grep BIONIC
#ifdef __BIONIC__
#else  // __BIONIC__ <-- two spaces
#endif // __BIONIC__
$ tip/of/tree/clang-format --version
clang-format version 12.0.0 (https://github.com/llvm/llvm-project.git 9776ac7c10c77e05ef1a7427b526e2f1f8f3c9c2)
$ tip/of/tree/clang-format z.cpp | grep BIONIC
#ifdef __BIONIC__
#else // __BIONIC__ <-- one space
#endif // __BIONIC__
```

LGTM, prefer new formatter to old


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89721/new/

https://reviews.llvm.org/D89721