[PATCH] D88655: [Flang][OpenMP][OpenACC] Support branching out issue in OpenMP parallel construct.

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 11:54:34 PDT 2020


clementval requested changes to this revision.
clementval added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Semantics/check-acc-structure.cpp:76
     // Restriction - 840 (PARALLEL)
-    CheckNoBranching(block, GetContext().directive, blockDir.source);
+    DirectiveStructureChecker::CheckNoBranching(
+        block, GetContext().directive, blockDir.source);
----------------
`DirectiveStructureChecker::` is not necessary here and it's not added for other checks. 


================
Comment at: flang/lib/Semantics/check-acc-structure.cpp:84
     // Restriction - 916
-    CheckNoBranching(block, llvm::acc::Directive::ACCD_serial, blockDir.source);
+    DirectiveStructureChecker::CheckNoBranching(
+        block, llvm::acc::Directive::ACCD_serial, blockDir.source);
----------------
`DirectiveStructureChecker::` is not necessary here and it's not added for other checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88655/new/

https://reviews.llvm.org/D88655



More information about the llvm-commits mailing list