[PATCH] D89618: [AMDGPU] Optimize waitcnt insertion for flat memory operations

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

LGTM modulo that inline question.



================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1248
+
+    if (TII->usesVM_CNT(Inst) && mayAccessVMEMThroughFlat(Inst)) {
+      ++FlatASCount;
----------------
arsenm wrote:
> When is usesVM_CNT false and isFLAT true?
I'd like to know as well. It may be better to make this an `assert(TII->usesVM_CNT(Inst))` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89618/new/

https://reviews.llvm.org/D89618