[PATCH] D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:129
   case Triple::ArchType::thumb:
-    return CPUType::Thumb;
+    return Triple.getOS() == Triple::Win32 ? CPUType::ARMNT : CPUType::Thumb;
   case Triple::ArchType::aarch64:
----------------
I think that `Triple.isOSWindows()` would be nicer than the explicit check to Win32.


================
Comment at: llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp:161
+    break;
+  default:
+    CpuType = CPUType::X64;
----------------
It might be nice to change this to explicitly:

```
case COFF::IMAGE_FILE_MACHINE_AMD64:
```

and add the x86 case and `llvm::fatal_error` in any other case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89622/new/

https://reviews.llvm.org/D89622