[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 19 03:32:03 PDT 2020
hans added a comment.
This broke Chromium's build, causing it to fail with
"Cannot pop empty stack!" from one of the backend passes.
That specific error is probably a perhaps a previously existing problem, but I think it was triggered by hot-cold-splitting getting enabled by this pass. This was a surprise to us, because we're not passing any flags to enable hot-cold-splitting, instead it seems to get enabled by this patch anyway in our PGO-enabled builds.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1139384#c5 for a repro.
I've reverted in 0628bea5137047232f37c94b74bf26aa9b55f605 <https://reviews.llvm.org/rG0628bea5137047232f37c94b74bf26aa9b55f605> until this can be investigated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57265/new/
https://reviews.llvm.org/D57265
More information about the llvm-commits
mailing list