[PATCH] D89460: [ARM][SchedModels] Convert IsCPSRDefinedPred to MCSchedPredicate

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp:192
+    const MCOperand &MO = MI.getOperand(I);
+    if (MO.isReg() && MO.getReg() == ARM::CPSR)
+      return true;
----------------
dmgreen wrote:
> It's not possible to check this is a Def?
> 
> I see a mvneq is not changed though. I'm guessing that predicate info is not added to MCInsts?
To check if a machine operand is a definition you need the MCInstrDesc.
But then, to obtain the MCInstrDesc you need to query the MCInstrInfo (method get()).

I think that it should be possible to use the new predicate introduced by D89553 to define functions that also check if operands are definitons.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89460/new/

https://reviews.llvm.org/D89460