[PATCH] D89562: [flang]Add Parser Support for OpenMP Allocate Directive

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Can you provide more information about the allocate directive in the summary/description of this patch?
-> Point to the section in the standard.
-> Explain that the standard specifies a declarative and executable version.

Also add tests for the executable version as well. Have both of them in the same test to show that the parser is not confused.
Add unparse tests for both versions.



================
Comment at: flang/include/flang/Parser/parse-tree.h:3626
+  CharBlock source;
+  std::tuple<Verbatim, OmpObjectList, Statement<AllocateStmt>> t;
+};
----------------
Rin wrote:
> The Allocate Directive can take the Allocator Clause as its only clause, but that clause doesn't seem to have been implemented yet. Should I add it myself before going forward with this patch or can this be done at a later time?
Yes, add that also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89562/new/

https://reviews.llvm.org/D89562