[PATCH] D88631: [X86] Support customizing stack protector guard

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3006
+
+  // TBD: Currently we just supported "tls" and "global" for X86 target.
+  // the "sysreg" will be supported in AArch64 later.
----------------
MaskRay wrote:
> We use TODO instead of TBD. 
> 
> Suggest: TODO: Support "sysreg" for AArch64.
> 
> If AArch64 is not supported yet, please don't accept an AArch64 specific value.
I tend to fix it, thanks your review!

And please let me sync with nick, because he has some suggestions here before.

@nickdesaulniers 
I find gcc 10.2 didn't support sysreg, So if you don't mind, I tend to remove it in next update.

```
$gcc -O2 -fstack-protector-all  -mstack-protector-guard=sysreg t.c -S -o -
gcc: error: unrecognized argument in option ‘-mstack-protector-guard=sysreg’
gcc: note: valid arguments to ‘-mstack-protector-guard=’ are: global tls
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88631/new/

https://reviews.llvm.org/D88631