[PATCH] D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1

[Martin Liška via Phabricator via llvm-commits]

marxin marked 3 inline comments as done.
marxin added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_thread.cpp:369
     bottom = fake_stack()->AddrIsInFakeStack(addr);
-    CHECK(bottom);
+    if (bottom == 0) {
+      return 0;
----------------
kcc wrote:
> when does this happen? When a variable is too large to fit in the fake stack? 
The function is only called from IsInvalidPointerPair which finds whether a pointer is a pointer to a stack/global/heap variable.
So it's fine to return 0 when the function is called for a non-stack variable and fake stacks are enabled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89552/new/

https://reviews.llvm.org/D89552