[PATCH] D88631: [X86] Support customizing stack protector guard

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:335
+
+  /// The base register of TLS. When stack protector use TLS guard style, we
+  /// choose the register for it. For example, we can use "fs" or "gs" register
----------------
Suggest: The TLS base register when StackProtectorGuard is "tls". On x86 this can be "fs" or "gs".


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3006
+
+  // TBD: Currently we just supported "tls" and "global" for X86 target.
+  // the "sysreg" will be supported in AArch64 later.
----------------
We use TODO instead of TBD. 

Suggest: TODO: Support "sysreg" for AArch64.

If AArch64 is not supported yet, please don't accept an AArch64 specific value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88631/new/

https://reviews.llvm.org/D88631