[PATCH] D89605: Add -prepend_rpath install-name-tool option

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 18 17:34:35 PDT 2020


alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:242
+
+  if (!Config.RPathToPrepend.empty())
+    Obj.updateLoadCommandIndexes();
----------------
tiny nit: would be good to add a comment that unlike the case where we add new load commands at the end of Obj.LoadCommands here the indexes have been invalidated and need to be updated. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89605/new/

https://reviews.llvm.org/D89605



More information about the llvm-commits mailing list