[llvm] f4d8e86 - [test][NFC] Do ptrdiff_t comparison with signed instead of unsigned constants

Hubert Tong via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 18 09:47:25 PDT 2020


Author: Hubert Tong
Date: 2020-10-18T12:38:41-04:00
New Revision: f4d8e86dbed599145490069fb547a87dbaff4a3e

URL: https://github.com/llvm/llvm-project/commit/f4d8e86dbed599145490069fb547a87dbaff4a3e
DIFF: https://github.com/llvm/llvm-project/commit/f4d8e86dbed599145490069fb547a87dbaff4a3e.diff

LOG: [test][NFC] Do ptrdiff_t comparison with signed instead of unsigned constants

... because using unsigned constants for comparing against signed values
is liable to mutate the signed value via conversion to an unsigned type
due to the usual arithmetic conversions.

Added: 
    

Modified: 
    llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp b/llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
index face8ec024fa..bdd4ca5b0199 100644
--- a/llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
+++ b/llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
@@ -200,7 +200,7 @@ TEST(DWARFDebugArangeSet, ZeroAddressEntry) {
                     Succeeded());
   auto Range = Set.descriptors();
   auto Iter = Range.begin();
-  ASSERT_EQ(std::distance(Iter, Range.end()), 1u);
+  ASSERT_EQ(std::distance(Iter, Range.end()), 1);
   EXPECT_EQ(Iter->Address, 0u);
   EXPECT_EQ(Iter->Length, 1u);
 }
@@ -227,7 +227,7 @@ TEST(DWARFDebugArangeSet, ZeroLengthEntry) {
                     Succeeded());
   auto Range = Set.descriptors();
   auto Iter = Range.begin();
-  ASSERT_EQ(std::distance(Iter, Range.end()), 1u);
+  ASSERT_EQ(std::distance(Iter, Range.end()), 1);
   EXPECT_EQ(Iter->Address, 1u);
   EXPECT_EQ(Iter->Length, 0u);
 }
@@ -256,7 +256,7 @@ TEST(DWARFDebugArangesSet, PrematureTerminator) {
   ASSERT_THAT_ERROR(Set.extract(Extractor, &Offset, Warnings), Succeeded());
   auto Range = Set.descriptors();
   auto Iter = Range.begin();
-  ASSERT_EQ(std::distance(Iter, Range.end()), 2u);
+  ASSERT_EQ(std::distance(Iter, Range.end()), 2);
   EXPECT_EQ(Iter->Address, 0u);
   EXPECT_EQ(Iter->Length, 0u);
   ++Iter;


        


More information about the llvm-commits mailing list