[PATCH] D89487: [AMDGPU] gfx1032 target
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 15 12:43:17 PDT 2020
rampitec added inline comments.
================
Comment at: clang/test/Driver/amdgpu-macros.cl:216
// GFX1031-DAG: #define FP_FAST_FMA 1
+// GFX1032-DAG: #define FP_FAST_FMA 1
----------------
tra wrote:
> This test could use some refactoring.
> Individual macro checks could be collapsed to
>
> ```
> // RUN: ... --check-prefixes=...,FMA
> // FMA-DAG: #define FP_FAST_FMA 1
> ```
>
Thanks! That makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89487/new/
https://reviews.llvm.org/D89487
More information about the llvm-commits
mailing list