[PATCH] D89487: [AMDGPU] gfx1032 target

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 12:41:21 PDT 2020


tra added a reviewer: yaxunl.
tra accepted this revision.
tra added a comment.

LGTM.



================
Comment at: clang/test/Driver/amdgpu-macros.cl:216
 // GFX1031-DAG: #define FP_FAST_FMA 1
+// GFX1032-DAG: #define FP_FAST_FMA 1
 
----------------
This test could use some refactoring.
Individual macro checks could be collapsed to

```
// RUN: ... --check-prefixes=...,FMA
//  FMA-DAG: #define FP_FAST_FMA 1
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89487/new/

https://reviews.llvm.org/D89487



More information about the llvm-commits mailing list