[PATCH] D89170: [AMDGPU] Select flat scratch instructions where available

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 12:54:52 PDT 2020


t-tye added a comment.

In D89170#2325299 <https://reviews.llvm.org/D89170#2325299>, @scott.linder wrote:

> I haven't done a meaningful review, but I wanted to note that this will require changes to the debug information (which isn't committed yet). I think this could be as simple as scaling the value of the SP/FP in the DWARF expression to recover the unswizzled scratch address.

Is this change changing the call convention ABI? For example, making the SP be a swizzled address as opposed to a swizzled address? If so then AMDGPUUsage will also need updating.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89170/new/

https://reviews.llvm.org/D89170



More information about the llvm-commits mailing list