[PATCH] D89644: [AMDGPU] Remove fix up operand from SI_ELSE

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 18 04:32:49 PDT 2020


critson created this revision.
critson added reviewers: nhaehnle, arsenm.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, qcolombet, MatzeB.
Herald added a project: LLVM.
critson requested review of this revision.
Herald added a subscriber: wdng.

Remove immediate operand from SI_ELSE which indicates if EXEC has
been modified.  Instead always emit code that handles EXEC and
remove unnecessary instructions during pre-RA optimisation.

This facilitates passes (i.e. SIWholeQuadMode) adding exec mask
manipulation post control flow lowering, and pre control flow
lower passes do not need to be aware of SI_ELSE handling.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89644

Files:
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/SIInstructions.td
  llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp
  llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
  llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-brcond.mir
  llvm/test/CodeGen/AMDGPU/collapse-endcf.mir
  llvm/test/CodeGen/AMDGPU/control-flow-fastregalloc.ll
  llvm/test/CodeGen/AMDGPU/lower-control-flow-other-terminators.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89644.298870.patch
Type: text/x-patch
Size: 14615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201018/2ae04cb8/attachment.bin>


More information about the llvm-commits mailing list