[PATCH] D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp:32
+  // this symbol is of internal linkage type.
+  std::string ModuleNameHash = (Twine(".uniq") + Twine(Str)).str();
   bool Changed = false;
----------------
mtrofin wrote:
> would .uniq. (so a dot before and after) fit more with existing other cases (like .llvm.)?
Thanks, .llvm. is indeed used when creating a promoted global name for a local with its original module ID.  So, .uniq. would be consistent with that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89617/new/

https://reviews.llvm.org/D89617