[PATCH] D89623: [MemCpyOpt] Move GEP during call slot optimization

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:920
+    return true;
+  };
+  if (!DominatesCall(cpyDest)) {
----------------
nikic wrote:
> I'm wondering if it would make sense to extend the `dominates()` API to accept a Value* instead of Instruction* as first argument. Handling "arguments, constants and globals dominate everything" seems like something the DominatorTree API should do, not the caller.
agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89623/new/

https://reviews.llvm.org/D89623