[compiler-rt] b7ff218 - [RISCV][ASAN] Fix passing XFAIL tests

Luís Marques via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 17 08:55:28 PDT 2020


Author: Luís Marques
Date: 2020-10-17T16:55:11+01:00
New Revision: b7ff218f1c0443aca4cd621ff01e44428b88e85f

URL: https://github.com/llvm/llvm-project/commit/b7ff218f1c0443aca4cd621ff01e44428b88e85f
DIFF: https://github.com/llvm/llvm-project/commit/b7ff218f1c0443aca4cd621ff01e44428b88e85f.diff

LOG: [RISCV][ASAN] Fix passing XFAIL tests

These tests pass for RV64 Linux, but they are marked as XFAIL. This patch
fixes that.

Differential Revision: https://reviews.llvm.org/D89299

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Linux/odr-violation.cpp
    compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Linux/odr-violation.cpp b/compiler-rt/test/asan/TestCases/Linux/odr-violation.cpp
index a14b59b67f11..4861220b11bb 100644
--- a/compiler-rt/test/asan/TestCases/Linux/odr-violation.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/odr-violation.cpp
@@ -1,7 +1,7 @@
 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
 // XFAIL: android
 // Fails with debug checks: https://bugs.llvm.org/show_bug.cgi?id=46862
-// XFAIL: !compiler-rt-optimized
+// XFAIL: !compiler-rt-optimized && !riscv64
 //
 // We use fast_unwind_on_malloc=0 to have full unwinding even w/o frame
 // pointers. This setting is not on by default because it's too expensive.

diff  --git a/compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp b/compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp
index eb0805784df1..024c488acda5 100644
--- a/compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp
@@ -1,5 +1,5 @@
 // Fails with debug checks: https://bugs.llvm.org/show_bug.cgi?id=46862
-// XFAIL: !compiler-rt-optimized
+// XFAIL: !compiler-rt-optimized && !riscv64
 
 // RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared %s -o %dynamiclib1
 // RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared %s -o %dynamiclib2


        


More information about the llvm-commits mailing list