[PATCH] D88390: [M68K] (Patch 4/8) MC layer and object file support

Sat Oct 17 07:13:35 PDT 2020

jrtc27 added inline comments.

================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/m680x0.def:5
+
+ELF_RELOC (R_M680x0_NONE,          0)  /* No reloc */
+ELF_RELOC (R_M680x0_32,            1)  /* Direct 32 bit  */
----------------
As I said on D88389:

They're all R_68K_FOO in system headers, please just use that name otherwise it gets confusing.

================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:1094
+    case ELF::EM_68K:
+      return "ELF32-M680x0";
     case ELF::EM_386:
----------------
As I said on D88389:

This gets reported in the file format line of llvm-objdump so should match what binutils has, which is elf32-m68k, though even if that weren't the case it should at least be in keeping with the style of all the others here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390