[PATCH] D67626: [IR] Merge metadata manipulation code into Value

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

Sadly I completely missed your update here. I’m skeptical there’s another `Value` subclass that needs or should have metadata (do you have something in mind?), but this is nevertheless a massive simplification and I like the direction!

If you’re still interested in pursuing this, please change the members you added to `Value` not to be public; you can make them protected and then in `Instruction` and `GlobalObject` I suggest adding `using` declarations. If a third category arises we can do the same there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67626/new/

https://reviews.llvm.org/D67626