[PATCH] D89458: [ARM][SchedModels] Convert IsPredicatedPred to MCSchedPredicate

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

I have been thinking a bit more about this patch.
D89553 <https://reviews.llvm.org/D89553> is surprisingly less complicated than I have originally thought it was. It definitely touches more files. However the majority of the changes are very mechanical (mostly boilerplate required for the new MCSchedPredicate to work). It is also a non-controversial change, since it doesn't modify the layout of MCInst.
Bonus point: by changing the signature of `resolveVariantSchedClass()` we potentially enable future developments in the area of MCSchedPredicate (and mca). Basically that change would make it possible for users to declare new predicates on MCinstrDesc (which is definitely not a bad thing!).

The more I look at D89553 <https://reviews.llvm.org/D89553>, the more I feel confident that it may be the right way to go. So, if you and @dmgreen are also happy with D89553 <https://reviews.llvm.org/D89553>, then please consider committing that patch instead of this one.

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89458/new/

https://reviews.llvm.org/D89458