[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 16:03:04 PDT 2020


aganea marked an inline comment as done.
aganea added inline comments.


================
Comment at: lld/Common/ErrorHandler.cpp:78
   }
-  _exit(val);
+  llvm::sys::Process::Exit(val);
 }
----------------
rnk wrote:
> This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`, not `_exit`, so now atexit destructors are run. That's unintended, right?
Yes, the fix is in D88348!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378



More information about the llvm-commits mailing list