[PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

[walter erquinigo via Phabricator via llvm-commits]

wallace added inline comments.


================
Comment at: llvm/include/llvm/Support/Error.h:1016
+/// expected-producer might be more clearly refactored to return an Optional<T>.
+template <typename T> inline void consumeExpected(Expected<T> E) {
+  if (!E)
----------------
vsk wrote:
> Probably best to not add another escape-hatch to permit fast and loose error handling. This seems to be used in a lambda passed to TraverseInstructions. There might be a way to avoid invoking the callback in the case where the expected value is thrown away.
Sure, will remove this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89283/new/

https://reviews.llvm.org/D89283