[PATCH] D89094: [objdump][macho] Check arch before formating reloc name as arm64 addend

Peng Guo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 14:58:53 PDT 2020


pguo added a comment.

I looked at the objdump macho unit tests. Looks like the yaml2obj is used only in a small portion of unit test, and majority are still binary inputs. For macho yaml input, it contains many magic numbers. So IMO it probably better to commit this simple change first, and improve objdump macho unit tests progressively.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89094/new/

https://reviews.llvm.org/D89094



More information about the llvm-commits mailing list