scott.linder created this revision.
Herald added subscribers: llvm-commits, kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: LLVM.
scott.linder requested review of this revision.
Herald added a subscriber: wdng.
- Fix typo "competing" -> "completing".
- Document reason waintcnt is added to store and not load for sequential consistent.
Cherry-pick of patch by Tony Tye
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89595
Files:
llvm/docs/AMDGPUUsage.rst
Index: llvm/docs/AMDGPUUsage.rst
===================================================================
--- llvm/docs/AMDGPUUsage.rst
+++ llvm/docs/AMDGPUUsage.rst
@@ -6137,8 +6137,17 @@
preventing a store preventing a store
release followed by release followed by
load acquire from load acquire from
- competing out of competing out of
- order.) order.)
+ completing out of completing out of
+ order. The waitcnt order. The waitcnt
+ could be placed after could be placed after
+ seq_store or before seq_store or before
+ the seq_load. We the seq_load. We
+ choose the load to choose the load to
+ make the waitcnt be make the waitcnt be
+ as late as possible as late as possible
+ so that the store so that the store
+ may have already may have already
+ completed.) completed.)
2. *Following 2. *Following
instructions same as instructions same as
@@ -6224,8 +6233,17 @@
preventing a store
release followed by
load acquire from
- competing out of
- order.)
+ completing out of
+ order. The waitcnt
+ could be placed after
+ seq_store or before
+ the seq_load. We
+ choose the load to
+ make the waitcnt be
+ as late as possible
+ so that the store
+ may have already
+ completed.)
2. *Following
instructions same as
@@ -6323,8 +6341,17 @@
preventing a store preventing a store
release followed by release followed by
load acquire from load acquire from
- competing out of competing out of
- order.) order.)
+ completing out of completing out of
+ order. The waitcnt order. The waitcnt
+ could be placed after could be placed after
+ seq_store or before seq_store or before
+ the seq_load. We the seq_load. We
+ choose the load to choose the load to
+ make the waitcnt be make the waitcnt be
+ as late as possible as late as possible
+ so that the store so that the store
+ may have already may have already
+ completed.) completed.)
2. *Following 2. *Following
instructions same as instructions same as
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89595.298755.patch
Type: text/x-patch
Size: 6254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201016/8daf8c4a/attachment.bin>