[PATCH] D89456: [SCEV] Introduce SCEVPtrToIntExpr (PR46786)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 13:17:59 PDT 2020


efriedma added a comment.

I think this looks good.  But I'd like a second opinion since this is a substantial change to SCEV modeling.



================
Comment at: llvm/unittests/Transforms/Utils/ScalarEvolutionExpanderTest.cpp:957
+    //       float addrspace(1)* %ptr = getelementptr inbounds float, float
+    //       addrspace(1)* null, i64 %offset ret float addrspace(1)* %uglygep2
+    //     }
----------------
Please reformat this to something readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89456/new/

https://reviews.llvm.org/D89456



More information about the llvm-commits mailing list