[PATCH] D87930: [DAG] Add BuildVectorSDNode::getRepeatedSequence helper to recognise multi-element splat patterns

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 13:09:31 PDT 2020


spatel added a comment.

I'm assuming we have enough splat codegen tests to be confident that the replacement code behaved the same.
Do you think it's worth creating an SDAG unit test for the new function to further verify?



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:1917
+  /// the vector width and set the bits where elements are undef.
+  /// If result is false, Sequence will be empty;
+  bool getRepeatedSequence(const APInt &DemandedElts,
----------------
punctuation: change ; to .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87930/new/

https://reviews.llvm.org/D87930



More information about the llvm-commits mailing list