[PATCH] D83427: [MSAN] Update tests due to widespread eager checking

[Gui Andrade via Phabricator via llvm-commits]

guiand added inline comments.


================
Comment at: compiler-rt/test/msan/vararg.cpp:40
+  __asm__ __volatile__ (""::"r"(a), "r"(b), "r"(c), "r"(d), "r"(e));
+}
+
----------------
vitalybuka wrote:
> is volatile needed here?
> noinline should be enough?
I wasn't sure if just using `noinline` would also prevent the compiler from doing dead code elimination on a call to an empty function.


================
Comment at: compiler-rt/test/msan/vararg.cpp:89
       return sum(7,
         a, a, a, a, a, a, uninit
       );
----------------
eugenis wrote:
> This test becomes super confusing, I no longer understand all the combinations.
> Why do you need explicit __msan_unpoison_param?
> It would help to rename EXPECT_PASS and EXPECT_FAIL to reflect what they do (pass uninit or not) instead of what they expect to happen.
> 
That's fair. I think this test could just be restored to its original state with the changes for noundef.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83427/new/

https://reviews.llvm.org/D83427