[PATCH] D88420: [InstCombine] matchFunnelShift - support non-uniform constant vector shift amounts (PR46895)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 10:25:17 PDT 2020


lebedev.ri added a comment.

In D88420#2335173 <https://reviews.llvm.org/D88420#2335173>, @saugustine wrote:

> It is a miscompile--or, at least a fingerprint is being miscomputed. The failure check is here:
>
> https://boringssl.googlesource.com/boringssl/+/refs/heads/master/crypto/hrss/hrss_test.cc#165
>
> But that is obviously somewhat removed from where things actually went wrong, which is what I'm (rather slowly, unfortunately) trying to figure out.

I think there were some related fixes afterwards. Is the issue still present in master?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88420/new/

https://reviews.llvm.org/D88420



More information about the llvm-commits mailing list