[PATCH] D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 09:50:14 PDT 2020


alexshap created this revision.
alexshap added reviewers: mtrent, lhames.
alexshap created this object with visibility "All Users".
Herald added a subscriber: hiraditya.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.
alexshap requested review of this revision.
Herald added a subscriber: MaskRay.

LD64 emits string tables which start with a space and a zero byte.
This diff adjusts StringTableBuilder for linked Mach-O binaries to match LD64's behavior.

Test plan: make check-all


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89561

Files:
  llvm/include/llvm/MC/StringTableBuilder.h
  llvm/lib/MC/StringTableBuilder.cpp
  llvm/test/tools/llvm-objcopy/MachO/basic-big-endian-64-copy.test
  llvm/test/tools/llvm-objcopy/MachO/basic-little-endian-64-copy.test
  llvm/test/tools/llvm-objcopy/MachO/code_signature_lc.test
  llvm/test/tools/llvm-objcopy/MachO/remove-swift-symbols.test
  llvm/test/tools/llvm-objcopy/MachO/segments-vmsize.test
  llvm/test/tools/llvm-objcopy/MachO/symbol-table.test
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.h
  llvm/unittests/MC/StringTableBuilderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89561.298652.patch
Type: text/x-patch
Size: 18662 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201016/944b916b/attachment.bin>


More information about the llvm-commits mailing list