[PATCH] D89371: [NPM] Port -loop-versioning-licm to NPM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Transforms/LoopVersioningLICM/loopversioningLICM1.ll:2
 ; RUN: opt < %s  -O1  -S -loop-versioning-licm -licm -debug-only=loop-versioning-licm 2>&1 | FileCheck %s
+; RUN: opt < %s -S -passes='loop(loop-versioning-licm),loop(licm)' --aa-pipeline=default -debug-only=loop-versioning-licm 2>&1 | FileCheck %s
 ; REQUIRES: asserts
----------------
TaWeiTu wrote:
> Running the two passes separately here to ensure the simplified and LCSSA loop structured of the versioned loops so that LICM works properly.
> Is there a better way to do so?
I think that's the proper way. I'm not super familiar with loop passes, I believe they must preserve LCSSA form, but do loop passes need to make sure that loop-simplify is a no-op if run after?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89371/new/

https://reviews.llvm.org/D89371