[PATCH] D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Thanks for this patch.

If I understand correctly all of the cases cannot be caught since the standard does not require it to be a constant expression. Can you add a few more tests which

1. Catches constant expressions, for eg:

   integer, parameter :: xx = 1
   integer, parameter :: yy = 1
  !$omp do schedule(STATIC, xx - yy)

2. Do not catch non-constant expressions

  subroutine sb(xx, yy)
    integer :: xx
    integer :: yy
   !$omp do schedule(STATIC, xx - yy)

   integer :: xx
  !$omp do schedule(STATIC, xx - xx)



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:613
+                "The chunk size of the schedule clause must be a"
+                " positive integer."_err_en_US,
+                ContextDirectiveAsFortran());
----------------
Nit: integer expression?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89546/new/

https://reviews.llvm.org/D89546