[PATCH] D89050: Add support for !noundef metatdata on loads

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 07:27:18 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. Would be best to split it now. Also one nit below.



================
Comment at: llvm/docs/LangRef.rst:9157
+      !<deref_bytes_node> = !{ i64 <dereferenceable_bytes> }
       !<align_node> = !{ i64 <value_alignment> }
 
----------------
The rewrite could be commited as NFC cleanup first. That part really makes things better :)


================
Comment at: llvm/docs/LangRef.rst:9248
+loaded is known to be well defined. If the value isn't well defined, the
+behavior is undefined.
+
----------------
reference to `well defined` (IIRC we have a section, right?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89050/new/

https://reviews.llvm.org/D89050



More information about the llvm-commits mailing list