[PATCH] D89458: [ARM][SchedModels] Convert IsPredicatedPred to MCSchedPredicate

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 05:36:05 PDT 2020


andreadb added a comment.

For the record, this is how your patch would look like if you decided to add a new predicate. F13319950: alternative-approach.diff <https://reviews.llvm.org/F13319950>
I am just trying to be helpful by showing how the alternative approach would look like (in case, if people decide that it is not a good idea to add an extra field to MCInst).

P.s.: I still think that your approach is simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89458/new/

https://reviews.llvm.org/D89458



More information about the llvm-commits mailing list