[PATCH] D89497: [LegalizeTypes] Legalize vector rotate operations

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:4318
   /// \returns True, if the expansion was successful, false otherwise
-  bool expandROT(SDNode *N, SDValue &Result, SelectionDAG &DAG) const;
+  bool expandROT(SDNode *N, bool IsVectorLowering, SDValue &Result,
+                 SelectionDAG &DAG) const;
----------------
Maybe call it AllowVectorOps ?

Add missing doxygen param.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6293
+  if (IsVectorLowering && (!isOperationLegalOrCustom(ISD::SHL, VT) ||
                         !isOperationLegalOrCustom(ISD::SRL, VT) ||
                         !isOperationLegalOrCustom(ISD::SUB, VT) ||
----------------
clang-format this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89497/new/

https://reviews.llvm.org/D89497