[PATCH] D89386: [AMDGPU] Fix access beyond the end of the basic block in execMayBeModifiedBeforeAnyUse.

Fri Oct 16 01:25:11 PDT 2020

vpykhtin added a comment.

In D89386#2332694 <https://reviews.llvm.org/D89386#2332694>, @rampitec wrote:

> In D89386#2331649 <https://reviews.llvm.org/D89386#2331649>, @vpykhtin wrote:
>
>> In D89386#2330465 <https://reviews.llvm.org/D89386#2330465>, @rampitec wrote:
>>
>>> Actually do we have a test with a call in between def and use?
>>
>> Probably not, how a call looks like at this stage?
>
> It should be s_setpc_b64 at this point and it is a terminator and branch. Although I am not sure it can be detected as an EXEC change.

DPP combiner is constrained to work on a def and uses in one BB, I assume if a call is a terminator then there should be no uses after it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89386/new/

https://reviews.llvm.org/D89386