[PATCH] D89378: [LoopFlatten] Loop limit invariant checks

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFlatten.cpp:439
     LLVM_DEBUG(dbgs() << "outer loop limit not invariant\n");
     return false;
   }
----------------
All these `return false` now need to return Changed, I think.


================
Comment at: llvm/test/Transforms/LoopFlatten/limit-not-invariant.ll:14
 ; CHECK-NEXT:    [[CONV4:%.*]] = sext i16 [[VAL:%.*]] to i32
+; CHECK-NEXT:    [[WIDE_TRIP_COUNT:%.*]] = zext i32 [[N]] to i64
 ; CHECK-NEXT:    br label [[FOR_COND1_PREHEADER_US:%.*]]
----------------
These tests don't then flatten?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89378/new/

https://reviews.llvm.org/D89378