[PATCH] D89490: Introduce __attribute__((darwin_abi))
Adrien Guinet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 15 23:22:09 PDT 2020
aguinet added inline comments.
================
Comment at: llvm/lib/IR/AsmWriter.cpp:379
+ Out << "aarch64_darwincc";
+ break;
case CallingConv::SPIR_FUNC: Out << "spir_func"; break;
----------------
mstorsjo wrote:
> The new code here has a different indentation than the rest; the same in a couple other places throughout the patch.
As clang-format changed that formatting for me, should I reformat the whole switch-case to be "clang-format compatible", or should we set this section as ignored?
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:876
SDValue LowerAAPCS_VASTART(SDValue Op, SelectionDAG &DAG) const;
+ SDValue LowerAAPCSFromDarwin_VASTART(SDValue Op, SelectionDAG &DAG) const;
SDValue LowerDarwin_VASTART(SDValue Op, SelectionDAG &DAG) const;
----------------
Same problem as with clang-format: clang-tidy suggests "lowerAapcsFromDarwinVastart", which would mean modifying the whole file for consistency. Should we set clang-tidy to ignore this file?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89490/new/
https://reviews.llvm.org/D89490
More information about the llvm-commits
mailing list